do not show add models and handle anonymous users#296603
Merged
Conversation
isidorn
approved these changes
Feb 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the "Add Language Models" / "Add Premium Models" UI section from the chat model picker dropdown and improves handling for anonymous users. The changes focus on streamlining the model picker by removing the bottom "Add Models" action and instead showing upgrade prompts inline on unavailable models (but only on the first one to avoid repetition).
Changes:
- Removed the "Add Models" section at the bottom of the model picker dropdown in
buildModelPickerItems - Added logic to show upgrade action links only on the first unavailable model (not subsequent ones) for better UX
- Removed
isProUserparameter frombuildModelPickerItemsand instead compute it internally from entitlement service - Registered a new
DEFAULT_ACCOUNT_SIGN_IN_COMMANDaction for signing in users - Updated all tests to use the new function signature and added tests for anonymous user behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/services/accounts/browser/defaultAccount.ts | Registers new sign-in command action |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Removes "Add Models" section, adds logic to show upgrade link only on first unavailable model, refactors to compute isPro internally |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts | Updates test helper and all tests for new function signature, adds tests for anonymous user behavior |
daviddossett
pushed a commit
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.