Align chat model picker ARIA semantics with single-selection menu behavior#296620
Merged
meganrogge merged 3 commits intomainfrom Feb 25, 2026
Merged
Align chat model picker ARIA semantics with single-selection menu behavior#296620meganrogge merged 3 commits intomainfrom
meganrogge merged 3 commits intomainfrom
Conversation
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix accessibility issue in model picker for screen readers
Align chat model picker ARIA semantics with single-selection menu behavior
Feb 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Chat Model Picker’s accessibility semantics so assistive technologies perceive it as a single-selection menu (radio-style) rather than a multi-toggle checkbox list, aligning ARIA roles with actual interaction behavior.
Changes:
- Switched model item ARIA role from
menuitemcheckboxtomenuitemradiowhile keeping checked-state announcements. - Extracted the picker accessibility provider into
getModelPickerAccessibilityProvider()and reused it at show-time. - Added a unit test validating widget/item roles (
menu,menuitemradio,separator).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Centralizes model picker list accessibility provider and updates action item role to menuitemradio. |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts | Adds coverage to ensure the accessibility provider returns the expected widget/item roles. |
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts
Outdated
Show resolved
Hide resolved
…cker.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sandy081
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat model picker exposed
checkboxsemantics to assistive tech, which is misleading because model selection behaves as a single-choice selection list. This updates the picker to announce radio-style menu semantics while preserving selected-state announcements.Accessibility semantics
menuitemcheckboxtomenuitemradioin the model picker accessibility provider.isChecked) so the active model remains announced as selected within the menu.Code structure
getModelPickerAccessibilityProvider()inchatModelPicker.ts.Coverage
menuitemradioseparatormenuOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.