GitService - add barrier for setting the delegate#296631
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a synchronization barrier to the GitService to prevent race conditions when attempting to open repositories before the Git extension delegate has been initialized. The barrier will automatically open after 10 seconds if the delegate hasn't been set.
Changes:
- Added AutoOpenBarrier to synchronize access to Git delegate initialization
- Added ILogService dependency for better error and warning logging
- Modified openRepository to wait for delegate initialization before proceeding
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/git/browser/gitService.ts:44
- When the delegate is removed via the returned disposable, the barrier remains open permanently. If the disposable is invoked and then setDelegate is called again with a new delegate, the barrier will already be open from the first call and won't provide synchronization for the second delegate initialization. This violates the stated invariant that the delegate can only be set once. Either the barrier should be recreated when the delegate is disposed, or the disposable should not allow resetting the delegate to undefined.
return toDisposable(() => {
this._delegate = undefined;
});
dmitrivMS
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.