Skip to content

Comments

add kb to navigate to next/previous question #296633

Merged
meganrogge merged 4 commits intomainfrom
merogge/navigate
Feb 20, 2026
Merged

add kb to navigate to next/previous question #296633
meganrogge merged 4 commits intomainfrom
merogge/navigate

Conversation

@meganrogge
Copy link
Collaborator

fix #296613

navigate.mov

Copilot AI review requested due to automatic review settings February 20, 2026 21:26
@meganrogge meganrogge self-assigned this Feb 20, 2026
@meganrogge meganrogge added this to the February 2026 milestone Feb 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds keyboard navigation shortcuts for the chat question carousel feature, implementing Alt+N (next question) and Alt+P (previous question) keybindings as requested in issue #296613.

Changes:

  • Added a new context key inChatQuestionCarousel to track when the question carousel has focus
  • Implemented navigateToPreviousQuestion() and navigateToNextQuestion() methods throughout the question carousel component stack
  • Registered keyboard actions with appropriate keybindings and accessibility help text

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/actions/chatContextKeys.ts Added inChatQuestionCarousel context key to detect when carousel is focused
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts Added context key tracking with focus listeners and implemented navigation methods with boundary checks
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Added navigation method delegation to the carousel widget
src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts Implemented IChatWidget interface methods for navigation
src/vs/workbench/contrib/chat/browser/chat.ts Added interface method declarations with JSDoc documentation
src/vs/workbench/contrib/chat/browser/actions/chatActions.ts Registered Alt+N and Alt+P keyboard actions with proper context conditions
src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts Added accessibility help text for the new navigation commands

@meganrogge meganrogge enabled auto-merge (squash) February 20, 2026 21:32
@meganrogge meganrogge merged commit 797e1c8 into main Feb 20, 2026
19 checks passed
@meganrogge meganrogge deleted the merogge/navigate branch February 20, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider Alt+N / Alt+P for next/previous question navigation when Question Widget is focused

2 participants