Fix welcome sessions list scrolling and archived session flicker#296637
Merged
daviddossett merged 1 commit intomainfrom Feb 20, 2026
Merged
Fix welcome sessions list scrolling and archived session flicker#296637daviddossett merged 1 commit intomainfrom
daviddossett merged 1 commit intomainfrom
Conversation
Add overrideExclude to the AgentSessionsFilter in the welcome view to exclude archived sessions from the tree data source, matching the height calculation in layoutSessionsControl which already filters them out.
osortega
approved these changes
Feb 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI bug in the welcome view where the sessions list allows unwanted scrolling and archived sessions flicker when scrolling. The root cause is a mismatch between the height calculation (which excludes archived sessions) and the filter data (which doesn't exclude them by default). The fix adds an overrideExclude callback to the filter to ensure archived sessions are excluded from the tree data, matching the height calculation logic.
Changes:
- Add
overrideExcludeoption toAgentSessionsFilterto exclude archived sessions in the welcome view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The welcome view sessions list allows scrolling even when there are only 1-2 items, and archived sessions flicker in when scrolling.
Root Cause
The container height in
layoutSessionsControl()is calculated based on non-archived sessions, but theAgentSessionsFilterdoesn't exclude archived sessions from the tree data source (it only does so whengroupResultsis set toCapped, which the welcome view doesn't use). This mismatch means the tree renders more items than the container is sized for, causing unwanted scrolling and archived session flicker.Fix
Add
overrideExcludeto the filter options to exclude archived sessions from the tree data, matching the height calculation.