Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes premature session creation in the Agent Sessions window by eliminating the createNewPendingSession method and refactoring LocalNewSession and RemoteNewSession to accept a URI directly instead of an IActiveSessionItem. The change implements a fully deferred session creation pattern where chat sessions are only created when the user sends their first request.
Changes:
- Removed
createNewPendingSessionmethod that was eagerly creating chat sessions before user interaction - Refactored
LocalNewSessionandRemoteNewSessionto accept URI resources directly instead ofIActiveSessionItem - Simplified
createNewSessionForTargetto construct new session objects without creating the underlying chat session
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/sessionsManagementService.ts | Removed createNewPendingSession method and updated createNewSessionForTarget to pass URI directly to LocalNewSession/RemoteNewSession constructors |
| src/vs/sessions/contrib/chat/browser/newSession.ts | Updated LocalNewSession and RemoteNewSession constructors to accept URI instead of IActiveSessionItem, removed unused import, and made resource a direct property instead of deriving it from activeSessionItem |
TylerLeonhardt
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.