Model picker search input styling and separator improvements#296645
Merged
daviddossett merged 6 commits intomainfrom Feb 20, 2026
Merged
Model picker search input styling and separator improvements#296645daviddossett merged 6 commits intomainfrom
daviddossett merged 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the model picker's search input styling and separator behavior to enhance the visual hierarchy and user experience. The changes add flexible filtering options to the ActionList component and refine how auxiliary actions (like "Manage Models...") are presented in action widget dropdowns.
Changes:
- Added filter customization options to
IActionListOptionsincluding filter position, focus behavior, and custom CSS class support - Updated model picker to use a minimal-styled search input that inherits font size and has custom spacing
- Removed separator between Auto and promoted models; added conditional separator before "Manage Models..." that only appears when Other Models section exists
- Enhanced ActionList to support section-aware separators that collapse with their parent section
- Refactored ActionWidgetDropdown to integrate auxiliary actions into the main list with proper accessibility roles
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Removed separator after Auto section, changed "Manage Models..." icon to blank, added conditional separator with section support, configured filter options (top position, focus on open, minimal class) |
| src/vs/platform/actionWidget/browser/actionWidgetDropdown.ts | Integrated auxiliary actions into main list with separator, prevented them from updating selectedOption, changed accessibility role to 'menuitem' for non-checkable auxiliary actions |
| src/vs/platform/actionWidget/browser/actionWidget.css | Added minimal class styling for filter input (inherited font size, adjusted padding, controlled borders) |
| src/vs/platform/actionWidget/browser/actionList.ts | Added filterPosition, focusFilterOnOpen, and filterInputClassName options; implemented section-aware separator filtering; updated focus logic to optionally focus filter on open |
hediet
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
focusFilterOnOpenoption toIActionListOptionsfor focusing the filter input when the list openssectionon separator items so they collapse with their sectionfilterPositionoption, always place filter on topfilterInputClassNameoption andfont-sizeoverride