Adopt unified js/ts setting for diagnostic settings#296677
Merged
mjbvz merged 3 commits intomicrosoft:mainfrom Feb 21, 2026
Merged
Adopt unified js/ts setting for diagnostic settings#296677mjbvz merged 3 commits intomicrosoft:mainfrom
mjbvz merged 3 commits intomicrosoft:mainfrom
Conversation
For microsoft#292934 Also renames validate.enable to `validate.enabled` to align with other settings
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeScript/JavaScript extension to adopt unified js/ts.* configuration keys for diagnostic-related settings (per #292934), including aligning validate.enable to the new validate.enabled naming while continuing to honor deprecated settings.
Changes:
- Introduces
js/ts.validate.enabledandjs/ts.reportStyleChecksAsWarningssettings and deprecates the olderjavascript.*/typescript.*equivalents. - Switches diagnostic validation reads to use
readUnifiedConfig(...)with fallback to deprecated keys (including thevalidate.enable→validate.enabledrename). - Updates localization strings for the new unified settings and deprecation messaging.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/typescript-language-features/src/utils/configuration.ts | Broadens configuration scope typing to vscode.ConfigurationScope for unified setting reads. |
| extensions/typescript-language-features/src/typeScriptServiceClientHost.ts | Reads reportStyleChecksAsWarnings via unified js/ts.* setting with fallback to typescript.*. |
| extensions/typescript-language-features/src/tsServer/bufferSyncSupport.ts | Moves validation enablement to unified js/ts.validate.enabled with fallback to deprecated validate.enable. |
| extensions/typescript-language-features/src/languageProvider.ts | Updates diagnostic/suggestion toggles to read unified settings using language-aware configuration scope. |
| extensions/typescript-language-features/package.nls.json | Adds localized strings for unified validation + deprecation messages. |
| extensions/typescript-language-features/package.json | Contributes new js/ts.* settings and deprecates old javascript.* / typescript.* settings. |
extensions/typescript-language-features/src/tsServer/bufferSyncSupport.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/tsServer/bufferSyncSupport.ts
Show resolved
Hide resolved
…cSupport.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dmitrivMS
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #292934
Also renames validate.enable to
validate.enabledto align with other settings