Skip to content

Comments

Adopt unified js/ts setting for diagnostic settings#296677

Merged
mjbvz merged 3 commits intomicrosoft:mainfrom
mjbvz:dev/mjbvz/rainy-grouse
Feb 21, 2026
Merged

Adopt unified js/ts setting for diagnostic settings#296677
mjbvz merged 3 commits intomicrosoft:mainfrom
mjbvz:dev/mjbvz/rainy-grouse

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Feb 21, 2026

For #292934

Also renames validate.enable to validate.enabled to align with other settings

For microsoft#292934

Also renames validate.enable to `validate.enabled` to align with other settings
Copilot AI review requested due to automatic review settings February 21, 2026 01:56
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TypeScript/JavaScript extension to adopt unified js/ts.* configuration keys for diagnostic-related settings (per #292934), including aligning validate.enable to the new validate.enabled naming while continuing to honor deprecated settings.

Changes:

  • Introduces js/ts.validate.enabled and js/ts.reportStyleChecksAsWarnings settings and deprecates the older javascript.* / typescript.* equivalents.
  • Switches diagnostic validation reads to use readUnifiedConfig(...) with fallback to deprecated keys (including the validate.enablevalidate.enabled rename).
  • Updates localization strings for the new unified settings and deprecation messaging.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
extensions/typescript-language-features/src/utils/configuration.ts Broadens configuration scope typing to vscode.ConfigurationScope for unified setting reads.
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts Reads reportStyleChecksAsWarnings via unified js/ts.* setting with fallback to typescript.*.
extensions/typescript-language-features/src/tsServer/bufferSyncSupport.ts Moves validation enablement to unified js/ts.validate.enabled with fallback to deprecated validate.enable.
extensions/typescript-language-features/src/languageProvider.ts Updates diagnostic/suggestion toggles to read unified settings using language-aware configuration scope.
extensions/typescript-language-features/package.nls.json Adds localized strings for unified validation + deprecation messages.
extensions/typescript-language-features/package.json Contributes new js/ts.* settings and deprecates old javascript.* / typescript.* settings.

…cSupport.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mjbvz mjbvz merged commit 78fba4c into microsoft:main Feb 21, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants