Skip to content

Comments

Use static product info for Show Release Notes command#296708

Merged
dmitrivMS merged 5 commits intomainfrom
dev/dmitriv/release-notes-menu
Feb 23, 2026
Merged

Use static product info for Show Release Notes command#296708
dmitrivMS merged 5 commits intomainfrom
dev/dmitriv/release-notes-menu

Conversation

@dmitrivMS
Copy link
Contributor

@dmitrivMS dmitrivMS commented Feb 21, 2026

Fixes #236533

Changes
Updated release notes and download commands to follow the same pattern as documentation as suggested in the issue.

Validation
Using a full build verified release notes menu shows up immediately after startup.

@dmitrivMS dmitrivMS added this to the February 2026 milestone Feb 21, 2026
@dmitrivMS dmitrivMS self-assigned this Feb 21, 2026
Copilot AI review requested due to automatic review settings February 21, 2026 08:30
@dmitrivMS dmitrivMS added the release-notes Release notes issues label Feb 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts update-related command registration/visibility so “Show Release Notes” (and related actions) don’t depend on context keys that may only be populated after the first menubar open, addressing the missing Help menu item on first window load.

Changes:

  • Removed release-notes/download URL context keys and their initialization from ProductContribution.
  • Updated “Show Release Notes” and “Download” actions to use static product configuration to decide whether to register the actions, instead of menu when/precondition context expressions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/update/browser/update.ts Removes context keys and the early binding of product URLs into context for menu gating.
src/vs/workbench/contrib/update/browser/update.contribution.ts Switches action visibility/registration logic to be decided via static product config, removing context-key-based conditions.
Comments suppressed due to low confidence (2)

src/vs/workbench/contrib/update/browser/update.contribution.ts:104

  • Gating registerAction2(ShowReleaseNotesAction) on AVAILABLE means the command update.showCurrentReleaseNotes is not registered at all when product.releaseNotesUrl is falsy. That command id is referenced from other parts of the workbench (e.g., built-in extension UI links), so this can turn those links into “command not found”. Prefer always registering the command and only conditionally contributing the Help menu item / visibility.
if (ShowReleaseNotesAction.AVAILABLE) {
	registerAction2(ShowReleaseNotesAction);
}

src/vs/workbench/contrib/update/browser/update.contribution.ts:179

  • DownloadAction.AVAILABLE is computed from the static product module, but web uses IProductService which can be overridden by an embedder. If an embedder supplies downloadUrl via configuration.productConfiguration, this action will never be registered even though productService.downloadUrl exists at runtime. Consider determining availability from IProductService (e.g., via a contribution) or registering unconditionally and hiding via a context expression that reflects IProductService.downloadUrl.
	static readonly ID = 'workbench.action.download';
	static readonly AVAILABLE = !!product.downloadUrl;

@dmitrivMS dmitrivMS marked this pull request as ready for review February 23, 2026 00:02
@dmitrivMS dmitrivMS enabled auto-merge (squash) February 23, 2026 00:03
@dmitrivMS dmitrivMS requested a review from joaomoreno February 23, 2026 03:01
@dmitrivMS dmitrivMS merged commit 234d552 into main Feb 23, 2026
19 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/release-notes-menu branch February 23, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes Release notes issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: No release notes item in help after first window load

2 participants