Merged
Conversation
benibenj
previously approved these changes
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the “New Session” flow in the Agent Sessions window by switching the UI to a dedicated new-session view and adjusting how pending sessions are tracked/sent.
Changes:
- Wire “New Session” actions/buttons to
openNewSessionView()instead ofopenNewSession(). - Rework pending session tracking in
SessionsManagementServiceto a singleMutableDisposable<INewSession>and update open/send logic accordingly. - Add “sending” UI state to the new chat widget to disable input and show loading while sending.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts | Updates “New Session” button to switch to the new-session view. |
| src/vs/sessions/contrib/sessions/browser/sessionsManagementService.ts | Renames/adjusts API for switching to new-session view; refactors pending session tracking and send flow. |
| src/vs/sessions/contrib/chat/browser/newChatViewPane.ts | Adds _sending state and updates send handling/loading UI behavior. |
| src/vs/sessions/contrib/chat/browser/chat.contribution.ts | Updates the sessions window “New Chat” action to open the new-session view. |
src/vs/sessions/contrib/sessions/browser/sessionsManagementService.ts
Outdated
Show resolved
Hide resolved
bpasero
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.