Revert "Raise keybinding precedence for chat question carousel and confirmation focus actions"#297000
Merged
meganrogge merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
…nfirmati…" This reverts commit 6955692.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #296616, which had raised the keybinding precedence for two chat-related focus actions from WorkbenchContrib (200) to ExternalExtension + 1 (401). The revert restores the standard keybinding weight for these actions.
Changes:
- Reverted keybinding weight for
FocusQuestionCarouselActionfromExternalExtension + 1back toWorkbenchContrib - Reverted keybinding weight for
AnnounceChatConfirmationActionfromExternalExtension + 1back toWorkbenchContrib
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Restored keybinding weight to WorkbenchContrib for the FocusQuestionCarouselAction (Cmd+Shift+A) |
| src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityActions.ts | Restored keybinding weight to WorkbenchContrib for the AnnounceChatConfirmationAction (Cmd+Shift+A) |
bpasero
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #296616