Merged
Conversation
- Remove INPUT_EDITOR_MIN_VISIBLE_LINES constant that forced 2-line minimum - Revert input editor height to content-based sizing - Add 8px margin-top on chat-input-toolbars for spacing between editor and toolbar
daviddossett
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the 2-line minimum height introduced in PR #296390 and replaces it with CSS-based spacing between the chat input editor and its toolbar. The change allows the input editor to size naturally to its content without a forced minimum height, while still maintaining visual breathing room through toolbar margin.
Changes:
- Remove the
INPUT_EDITOR_MIN_VISIBLE_LINESconstant and associated min-height calculation logic - Simplify input editor height calculation to use only content height (capped at max)
- Add top margin to
.chat-input-toolbarsfor spacing between editor and toolbar
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Removed INPUT_EDITOR_MIN_VISIBLE_LINES constant, unused EditorOption import, and min-height calculation logic from layout function |
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Added margin-top: 4px to .chat-input-toolbars to create spacing between editor and toolbar |
Yoyokrazy
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the 2-line minimum height on the chat input editor, replacing it with 8px of margin between the editor and toolbar for breathing room without adding a full extra line.
Changes:
INPUT_EDITOR_MIN_VISIBLE_LINESconstant and min-height logic (from Update chat input: hide attachments bar, move/restyle context window hint #296390)margin-top: 4pxon.chat-input-toolbarsfor spacing