Skip to content

Comments

[html/css/json] update services#297113

Merged
aeschli merged 1 commit intomainfrom
aeschli/rear-cow-982
Feb 23, 2026
Merged

[html/css/json] update services#297113
aeschli merged 1 commit intomainfrom
aeschli/rear-cow-982

Conversation

@aeschli
Copy link
Contributor

@aeschli aeschli commented Feb 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 23, 2026 21:54
@aeschli aeschli enabled auto-merge (squash) February 23, 2026 21:54
@aeschli aeschli self-assigned this Feb 23, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the language service dependencies for HTML, CSS, and JSON language features extensions. The updates include newer versions of vscode-languageserver, vscode-languageclient, and various language service packages, along with API improvements to add proper type annotations.

Changes:

  • Updated vscode-languageserver from 10.0.0-next.15 to 10.0.0-next.16 across all language server packages
  • Updated vscode-languageclient to 10.0.0-next.20 for JSON and CSS extensions (but incorrectly to 10.0.0-next.10 for HTML)
  • Updated language service packages (vscode-json-languageservice, vscode-html-languageservice, vscode-css-languageservice) to latest versions
  • Added proper type annotations for TextDocumentContentRequest handler in htmlServer.ts
  • Changed AutoInsertRequest return type to allow null values

Reviewed changes

Copilot reviewed 9 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
extensions/json-language-features/server/package.json Updated vscode-json-languageservice to 5.7.2 and vscode-languageserver to 10.0.0-next.16
extensions/json-language-features/server/package-lock.json Regenerated lock file with updated dependencies including vscode-jsonrpc 9.0.0-next.11
extensions/json-language-features/package.json Updated vscode-languageclient to 10.0.0-next.20
extensions/json-language-features/package-lock.json Regenerated with updated vscode-languageclient and transitive dependencies
extensions/html-language-features/server/src/htmlServer.ts Added type annotations (TextDocumentContentParams, CancellationToken, TextDocumentContentResult) and changed return value from null to { text: '' }
extensions/html-language-features/server/package.json Updated vscode-css-languageservice to 6.3.10, vscode-html-languageservice to 5.6.2, and vscode-languageserver to 10.0.0-next.16
extensions/html-language-features/server/package-lock.json Regenerated lock file with updated dependencies
extensions/html-language-features/package.json CRITICAL ISSUE: Updated vscode-languageclient to 10.0.0-next.10 (should be 10.0.0-next.20)
extensions/html-language-features/package-lock.json Package lock file out of sync with package.json
extensions/html-language-features/client/src/htmlClient.ts Updated AutoInsertRequest return type to allow null
extensions/html-language-features/client/src/autoInsertion.ts Updated provider function type to return string or null
extensions/css-language-features/server/package.json Updated vscode-css-languageservice to 6.3.10 and vscode-languageserver to 10.0.0-next.16
extensions/css-language-features/server/package-lock.json Regenerated lock file with updated dependencies
extensions/css-language-features/package.json Updated vscode-languageclient to 10.0.0-next.20
extensions/css-language-features/package-lock.json Regenerated with updated vscode-languageclient and transitive dependencies
Files not reviewed (6)
  • extensions/css-language-features/package-lock.json: Language not supported
  • extensions/css-language-features/server/package-lock.json: Language not supported
  • extensions/html-language-features/package-lock.json: Language not supported
  • extensions/html-language-features/server/package-lock.json: Language not supported
  • extensions/json-language-features/package-lock.json: Language not supported
  • extensions/json-language-features/server/package-lock.json: Language not supported

"dependencies": {
"@vscode/extension-telemetry": "^0.9.8",
"vscode-languageclient": "^10.0.0-next.18",
"vscode-languageclient": "^10.0.0-next.10",
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vscode-languageclient version is inconsistent with the other language features. The JSON and CSS language features are being updated to version 10.0.0-next.20, but this is being updated to 10.0.0-next.10 which is actually a downgrade from the current version (10.0.0-next.18 shown in package-lock.json). This should be changed to 10.0.0-next.20 to match the other extensions and ensure consistency across all language features.

Suggested change
"vscode-languageclient": "^10.0.0-next.10",
"vscode-languageclient": "^10.0.0-next.20",

Copilot uses AI. Check for mistakes.
"dependencies": {
"@vscode/extension-telemetry": "^0.9.8",
"vscode-languageclient": "^10.0.0-next.18",
"vscode-languageclient": "^10.0.0-next.10",
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.json needs to be regenerated after updating vscode-languageclient to version 10.0.0-next.20 in package.json. The lock file currently shows version 10.0.0-next.18 which doesn't match the requested version 10.0.0-next.10 in package.json, indicating this file is out of sync.

Suggested change
"vscode-languageclient": "^10.0.0-next.10",
"vscode-languageclient": "^10.0.0-next.20",

Copilot uses AI. Check for mistakes.
@aeschli aeschli merged commit 36d4249 into main Feb 23, 2026
23 of 24 checks passed
@aeschli aeschli deleted the aeschli/rear-cow-982 branch February 23, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants