Update viewpane filter container to use :has selector for focus state#297383
Merged
mrleemurray merged 2 commits intomainfrom Feb 24, 2026
Merged
Update viewpane filter container to use :has selector for focus state#297383mrleemurray merged 2 commits intomainfrom
mrleemurray merged 2 commits intomainfrom
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the panel header viewpane filter container’s “expanded” focus styling to use a :has(...) selector, aiming to prevent the filter input from jumping when clicked (issue #277988).
Changes:
- Replace
:active/:focus-within-based expansion with:has(.monaco-inputbox .input:focus)for the viewpane filter container in panel titles.
rzhao271
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the viewpane filter container to utilize the
:hasselector for improved focus state handling. This change enhances the user experience by ensuring the focus state is applied correctly when an input box within the container is focused. Testing can be done by interacting with the viewpane filter and observing the focus behavior.Addresses: #277988