Fix detected attachment sticking around after editor is closed#297400
Merged
daviddossett merged 1 commit intomainfrom Feb 24, 2026
Merged
Fix detected attachment sticking around after editor is closed#297400daviddossett merged 1 commit intomainfrom
daviddossett merged 1 commit intomainfrom
Conversation
When all editors are closed, the implicit context should be cleared. Previously, the guard condition preserved stale values because `newValue` was undefined and `hasValue` was true. Now we also check `hasActiveEditor` — if there's no active editor at all, values are cleared instead of preserved.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the chat implicit context (detected attachment) incorrectly persists after all editors are closed. The issue stemmed from the guard condition in updateImplicitContext preserving stale values when both newValue was undefined and hasValue was true.
Changes:
- Modified the implicit context update logic to check if there's any active editor at all, clearing values when no editors are open while still preserving them for non-code editors like Settings
src/vs/workbench/contrib/chat/browser/attachments/chatImplicitContext.ts
Show resolved
Hide resolved
Yoyokrazy
approved these changes
Feb 24, 2026
daviddossett
deleted the
daviddossett/fix-implicit-context-stale-attachment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297284
When all editors are closed, the implicit context (detected attachment) should be cleared. Previously, the guard condition in
updateImplicitContextpreserved stale values becausenewValuewasundefinedandhasValuewastrue— both sides of the OR were false, sosetValueswas never called.Now we also check whether there's any active editor. If there's no active editor at all (all editors closed), the values are cleared instead of preserved. The preserve behavior still applies when a non-code editor (e.g. Settings) is active.