Inform if user is internal during update requests#297464
Merged
joaomoreno merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors how VS Code determines and communicates internal user status to the update service. Previously, the update service had a disableProgressiveReleases() method that was called when internal users (specifically Visual-Studio-Code org members) were detected. The new approach introduces a setInternalOrg() method that accepts the detected internal organization identifier ('vscode', 'github', or 'microsoft') and includes this information in update feed URL requests.
Changes:
- Extracted internal organization detection logic into a shared
getInternalOrg()utility function inplatform/assignment - Replaced
IUpdateService.disableProgressiveReleases()withsetInternalOrg(internalOrg: string | undefined)across all update service implementations - Modified
DefaultAccountUpdateContributionto detect, persist, and communicate internal org status to the update service - Updated update feed URL construction to include internal org information via
orgquery parameter
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/assignment/common/assignment.ts | Added getInternalOrg() utility function to centralize internal organization detection logic |
| src/vs/workbench/services/assignment/common/assignmentFilters.ts | Refactored to use shared getInternalOrg() utility instead of duplicating detection logic |
| src/vs/platform/update/common/update.ts | Updated IUpdateService interface: replaced disableProgressiveReleases() with setInternalOrg() |
| src/vs/platform/update/common/updateIpc.ts | Updated IPC channel to handle setInternalOrg method instead of disableProgressiveReleases |
| src/vs/platform/update/electron-main/abstractUpdateService.ts | Implemented setInternalOrg() with logging; replaced boolean flag with string storage; added internalOrg to URL options |
| src/vs/platform/update/electron-main/updateService.win32.ts | Updated to use getInternalOrg() and pass internalOrg to update feed URL |
| src/vs/platform/update/electron-main/updateService.linux.ts | Updated to use getInternalOrg() and pass internalOrg to update feed URL |
| src/vs/platform/update/electron-main/updateService.darwin.ts | Updated to use getInternalOrg() and pass internalOrg to update feed URL in both check and download flows |
| src/vs/platform/update/electron-main/updateService.snap.ts | Added no-op setInternalOrg() implementation (not applicable for snap) |
| src/vs/workbench/services/update/browser/updateService.ts | Added no-op setInternalOrg() implementation (not applicable in browser) |
| src/vs/workbench/contrib/update/browser/update.ts | Refactored DefaultAccountUpdateContribution to track and persist internal org status using throttled refresh pattern and storage |
Yoyokrazy
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update service now includes functionality to determine if a user is internal. This change introduces a new method,
setInternalOrg, which logs the internal organization when invoked. The update process will also utilize this information to adjust the update feed URL accordingly. Testing can be done by checking the logs for the internal organization information during update requests.Fixes #297453