Skip to content

fallback to a model when none is available on the chat widget#297471

Merged
meganrogge merged 2 commits intomainfrom
merogge/output-fix2
Feb 25, 2026
Merged

fallback to a model when none is available on the chat widget#297471
meganrogge merged 2 commits intomainfrom
merogge/output-fix2

Conversation

@meganrogge
Copy link
Collaborator

Copilot AI review requested due to automatic review settings February 24, 2026 20:04
@meganrogge meganrogge self-assigned this Feb 24, 2026
@meganrogge meganrogge added this to the February 2026 milestone Feb 24, 2026
@meganrogge meganrogge enabled auto-merge (squash) February 24, 2026 20:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the terminal OutputMonitor’s option auto-reply flow to handle cases where the Chat widget doesn’t currently expose an active model, addressing microsoft/vscode-copilot-evaluation#2709.

Changes:

  • Add fallback model resolution for option prompts when the Chat widget has no currentLanguageModel.
  • Make model-based option suggestion resilient to model lookup/request failures, and fall back to the first option when auto-reply is enabled.
  • Extend the OutputMonitor test setup with configuration/chat widget service stubs and add a new auto-reply fallback test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/outputMonitor.test.ts Adds service stubs required by OutputMonitor and introduces a new test for auto-reply fallback behavior.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts Implements fallback language model selection and guarded model querying when choosing a default terminal prompt option.

@meganrogge meganrogge marked this pull request as draft February 24, 2026 20:13
auto-merge was automatically disabled February 24, 2026 20:13

Pull request was converted to draft

@meganrogge meganrogge merged commit 0c71b23 into main Feb 25, 2026
20 checks passed
@meganrogge meganrogge deleted the merogge/output-fix2 branch February 25, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants