fallback to a model when none is available on the chat widget#297471
Merged
meganrogge merged 2 commits intomainfrom Feb 25, 2026
Merged
fallback to a model when none is available on the chat widget#297471meganrogge merged 2 commits intomainfrom
meganrogge merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the terminal OutputMonitor’s option auto-reply flow to handle cases where the Chat widget doesn’t currently expose an active model, addressing microsoft/vscode-copilot-evaluation#2709.
Changes:
- Add fallback model resolution for option prompts when the Chat widget has no
currentLanguageModel. - Make model-based option suggestion resilient to model lookup/request failures, and fall back to the first option when auto-reply is enabled.
- Extend the OutputMonitor test setup with configuration/chat widget service stubs and add a new auto-reply fallback test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/outputMonitor.test.ts | Adds service stubs required by OutputMonitor and introduces a new test for auto-reply fallback behavior. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts | Implements fallback language model selection and guarded model querying when choosing a default terminal prompt option. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/outputMonitor.test.ts
Show resolved
Hide resolved
...s/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts
Show resolved
Hide resolved
auto-merge was automatically disabled
February 24, 2026 20:13
Pull request was converted to draft
pwang347
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix https://github.com/microsoft/vscode-copilot-evaluation/issues/2709