Skip to content

fix updating the model when sending the request#297685

Merged
sandy081 merged 1 commit intomainfrom
sandy081/balanced-meadowlark
Feb 25, 2026
Merged

fix updating the model when sending the request#297685
sandy081 merged 1 commit intomainfrom
sandy081/balanced-meadowlark

Conversation

@sandy081
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings February 25, 2026 14:16
@sandy081 sandy081 enabled auto-merge (squash) February 25, 2026 14:16
@sandy081 sandy081 self-assigned this Feb 25, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the model selection state when sending a request for a new session in the Agent Sessions window. The fix ensures that the selected model is properly applied to the chat input state before the request is sent, so the model picker UI reflects the user's selection.

Changes:

  • Added ILanguageModelsService injection to SessionsManagementService to enable model metadata lookup
  • Refactored model state initialization to unconditionally acquire the model reference and set the selected model on the input state
  • Moved the modelRef.dispose() call outside the conditional block to ensure proper cleanup

@sandy081 sandy081 merged commit c86ede2 into main Feb 25, 2026
24 checks passed
@sandy081 sandy081 deleted the sandy081/balanced-meadowlark branch February 25, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants