Revert "vscode internal tool for getting userdata home (#297674)"#297694
Merged
Revert "vscode internal tool for getting userdata home (#297674)"#297694
Conversation
This reverts commit 88eb9d7.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previously introduced internal chat tool for retrieving the user data home path, and rolls back the associated prompt/agent “icon” plumbing in the prompt syntax + agent model.
Changes:
- Removes
GetUserDataHomeToolimplementation, registration, and its unit test. - Removes
iconsupport from custom agent prompt headers andICustomAgentshape, updating parsing/service logic and tests accordingly. - Updates
CustomChatModeto no longer track an icon observable (custom modes now expose no icon).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/tools/builtinTools/getUserDataHomeTool.test.ts | Deletes the unit test for the reverted tool. |
| src/vs/workbench/contrib/chat/test/common/promptSyntax/service/promptsService.test.ts | Updates expected agent objects to no longer include icon. |
| src/vs/workbench/contrib/chat/common/tools/builtinTools/tools.ts | Removes registration of GetUserDataHomeTool. |
| src/vs/workbench/contrib/chat/common/tools/builtinTools/getUserDataHomeTool.ts | Deletes the reverted tool implementation and metadata. |
| src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts | Stops reading/returning icon from parsed agent headers. |
| src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsService.ts | Removes icon from the ICustomAgent interface. |
| src/vs/workbench/contrib/chat/common/promptSyntax/promptFileParser.ts | Removes the icon header attribute constant + getter. |
| src/vs/workbench/contrib/chat/common/chatModes.ts | Removes custom-mode icon observable wiring; custom modes now expose no icon. |
Comment on lines
339
to
341
| get icon(): IObservable<ThemeIcon | undefined> { | ||
| return this._iconObservable; | ||
| return constObservable(undefined); | ||
| } |
There was a problem hiding this comment.
CustomChatMode.icon now returns constObservable(undefined) directly from the getter, which creates a new observable instance on every access. Consider caching a single observable (e.g. a private readonly field or static const observable) to avoid repeated allocations and to keep the observable reference stable for subscribers.
aeschli
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 88eb9d7.