Add depth shadows for panels in the editor#297717
Merged
mrleemurray merged 2 commits intomainfrom Feb 25, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the visual hierarchy in the VS Code editor by replacing problematic z-index stacking with a shadow-based depth system. The change addresses issues where z-index manipulation on panels was breaking webviews, iframes, and sashes. Instead, the editor now draws "received shadows" via a ::after pseudo-element to create the illusion that surrounding panels (sidebar, panel, auxiliarybar) float above it.
Changes:
- Added CSS variables for panel depth shadows with separate values for light and dark themes
- Removed all z-index rules from panels, sidebars, sashes, webviews, and notebooks that were causing stacking issues
- Implemented inset shadows on the editor's
::afterpseudo-element that adapt based on panel position and sidebar location
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sandy081
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance UI layering by adding depth shadows for panels in the editor. This change improves the visual hierarchy and makes panels appear to float above the editor surface, whilst removing the z-index manipulation that was causing unintended issues.
Addresses: #297640