Improve discoverability of browser open tool#297724
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the discoverability of the browser “open page” tool by removing explicit references to its tool id from other browser tool metadata, reducing noise in tool-search ranking.
Changes:
- Updated
pageIdinput schema descriptions across browser tools to avoid mentioningOpenPageToolIddirectly.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/tools/typeBrowserTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/screenshotBrowserTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/runPlaywrightCodeTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/readBrowserTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/navigateBrowserTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/hoverElementTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/handleDialogBrowserTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/dragElementTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/clickBrowserTool.ts | Rewords pageId schema description to avoid referencing the open tool id. |
src/vs/workbench/contrib/browserView/electron-browser/tools/readBrowserTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/navigateBrowserTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/typeBrowserTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/screenshotBrowserTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/runPlaywrightCodeTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/hoverElementTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/handleDialogBrowserTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/dragElementTool.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/clickBrowserTool.ts
Show resolved
Hide resolved
roblourens
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297723.
The issue is that the tool search tool only returns a limited number of results, and they may not be prioritized as expected. So we shouldn't reference the open tool name in other tools to keep the results clean.