Skip to content

fix chat tip getting stuck when mode changes#297744

Merged
meganrogge merged 1 commit intomainfrom
merogge/switch-tip
Feb 25, 2026
Merged

fix chat tip getting stuck when mode changes#297744
meganrogge merged 1 commit intomainfrom
merogge/switch-tip

Conversation

@meganrogge
Copy link
Collaborator

fix #297287

Copilot AI review requested due to automatic review settings February 25, 2026 18:05
@meganrogge meganrogge changed the title fix chat tip getting stuck whem mode changes fix chat tip getting stuck when mode changes Feb 25, 2026
@meganrogge meganrogge self-assigned this Feb 25, 2026
@meganrogge meganrogge added this to the February 2026 milestone Feb 25, 2026
@meganrogge meganrogge enabled auto-merge (squash) February 25, 2026 18:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the “getting started” chat tip widget getting stuck (showing only one tip with broken next/previous arrows) after switching chat modes (e.g., Local → Cloud) by ensuring the rendered tip is cleared when a new chat session/model is bound.

Changes:

  • Clear any previously-rendered getting-started tip DOM + disposables when switching to a new chat model/session.
  • Hide the tip container so the next empty-state render selects and renders a fresh, context-appropriate tip.
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts:2085

  • This tip-clearing sequence is now duplicated in multiple places (config toggle handler, updateChatViewVisibility non-empty path, and here). Consider extracting a small private helper (e.g. clearGettingStartedTip()) to centralize the DOM + disposable cleanup and reduce the chance these paths drift over time.
		// Switching sessions resets tip service state; clear any rendered tip so
		// empty-state rendering picks a fresh, context-appropriate tip.
		this._gettingStartedTipPartRef = undefined;
		this._gettingStartedTipPart.clear();
		const tipContainer = this.inputPart.gettingStartedTipContainerElement;
		dom.clearNode(tipContainer);
		dom.setVisibility(false, tipContainer);

@meganrogge meganrogge merged commit e2c2a7d into main Feb 25, 2026
24 checks passed
@meganrogge meganrogge deleted the merogge/switch-tip branch February 25, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching from Local to Cloud results in one tip being shown only without arrows working

3 participants