fix chat tip getting stuck when mode changes#297744
Merged
meganrogge merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the “getting started” chat tip widget getting stuck (showing only one tip with broken next/previous arrows) after switching chat modes (e.g., Local → Cloud) by ensuring the rendered tip is cleared when a new chat session/model is bound.
Changes:
- Clear any previously-rendered getting-started tip DOM + disposables when switching to a new chat model/session.
- Hide the tip container so the next empty-state render selects and renders a fresh, context-appropriate tip.
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts:2085
- This tip-clearing sequence is now duplicated in multiple places (config toggle handler, updateChatViewVisibility non-empty path, and here). Consider extracting a small private helper (e.g. clearGettingStartedTip()) to centralize the DOM + disposable cleanup and reduce the chance these paths drift over time.
// Switching sessions resets tip service state; clear any rendered tip so
// empty-state rendering picks a fresh, context-appropriate tip.
this._gettingStartedTipPartRef = undefined;
this._gettingStartedTipPart.clear();
const tipContainer = this.inputPart.gettingStartedTipContainerElement;
dom.clearNode(tipContainer);
dom.setVisibility(false, tipContainer);
bpasero
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #297287