disable next/previous tip actions when only one remains#297747
Merged
meganrogge merged 2 commits intomainfrom Feb 25, 2026
Merged
disable next/previous tip actions when only one remains#297747meganrogge merged 2 commits intomainfrom
meganrogge merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #297391 where the next/previous tip navigation buttons were active even when only one tip remained, leading to confusing behavior when clicked.
Changes:
- Adds a new context key
multipleChatTipsto track when multiple tips are available - Disables next/previous navigation buttons when only one eligible tip remains
- Refactors tip navigation logic to count eligible tips before allowing navigation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/actions/chatContextKeys.ts | Adds multipleChatTips context key definition |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatTipContentPart.ts | Binds and updates multipleChatTips context key; adds preconditions to navigation actions |
| src/vs/workbench/contrib/chat/browser/chatTipService.ts | Implements hasMultipleTips() method and refactors navigation logic to count eligible tips |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
connor4312
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #297391