sessions - hide title bar actions when welcome overlay shows#297958
Merged
sessions - hide title bar actions when welcome overlay shows#297958
Conversation
bpasero
changed the title
SessionsWelcomeVisibleContext for overlays
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new sessions-specific context key to indicate when the Sessions welcome overlay is currently shown, and uses it to suppress title bar/menu actions that shouldn’t be available while the overlay is up.
Changes:
- Introduce
SessionsWelcomeVisibleContext(sessionsWelcomeVisible) in sessions context keys. - Set/unset the context key while the welcome overlay is active.
- Gate multiple Sessions title bar menu entries behind
!sessionsWelcomeVisible.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/welcome/browser/welcome.contribution.ts | Binds and toggles the new context key while the welcome overlay is shown. |
| src/vs/sessions/contrib/terminal/browser/sessionsTerminalContribution.ts | Hides “Open Terminal” title bar action when the welcome overlay is visible. |
| src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts | Hides the Sessions command-center submenu entry when the welcome overlay is visible. |
| src/vs/sessions/contrib/chat/browser/runScriptAction.ts | Hides the “Run” title bar split-button submenu when the welcome overlay is visible. |
| src/vs/sessions/contrib/chat/browser/chat.contribution.ts | Hides “Open in VS Code” title bar action when the welcome overlay is visible. |
| src/vs/sessions/common/contextkeys.ts | Defines SessionsWelcomeVisibleContext raw context key. |
| src/vs/sessions/browser/layoutActions.ts | Hides sidebar toggle title bar actions when the welcome overlay is visible. |
src/vs/sessions/contrib/welcome/browser/welcome.contribution.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alexr00
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.