sessions - add hideSkipButton option and refactor dialog options#297976
Merged
sessions - add hideSkipButton option and refactor dialog options#297976
Conversation
bpasero
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dialogHideSkip option to the chat setup dialog and refactors the chat setup logic in the Sessions window. The new option allows callers to hide the "Skip for now" button in the chat setup dialog, making it mandatory for users to complete the setup process. In the Sessions window, the chat setup logic has been moved from the NewChatWidget to a centralized SessionsWelcomeOverlay, improving code organization and reducing duplication.
Changes:
- Added
dialogHideSkipboolean option to chat setup actions and runner to control visibility of the "Skip for now" button - Removed duplicate chat setup logic from
NewChatWidgetin favor of the centralizedSessionsWelcomeOverlay - Removed unused service dependencies (
ICommandService,IChatEntitlementService) fromNewChatWidget
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupRunner.ts | Added dialogHideSkip parameter to control dialog close button behavior; when true, uses close button instead of "Skip for now" button |
| src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts | Added dialogHideSkip parameter to action signatures and passes it through to setup runner |
| src/vs/sessions/contrib/welcome/browser/welcome.contribution.ts | Uses dialogHideSkip: true when triggering setup from welcome overlay to prevent skipping |
| src/vs/sessions/contrib/chat/browser/newChatViewPane.ts | Removed duplicate chat setup logic and unused dependencies; setup now handled by welcome overlay |
ulugbekna
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.