Improve CSS handling on theme change#298011
Merged
mrleemurray merged 2 commits intomainfrom Feb 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances CSS management during theme changes by ensuring that cached stylesheets are properly cleared when a theme becomes inactive. The changes prevent outdated styles from persisting and improve the reliability of theme switching.
Changes:
- Added cleanup logic to remove cached CSS when an extension's theme becomes inactive during extension handling
- Refactored the
onThemeChange()method to separate activation and deactivation logic - Added comprehensive deactivation sweep to clear all inactive extension stylesheets
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joaomoreno
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the CSS management during theme changes by ensuring that cached stylesheets are cleared when a theme is no longer active. This prevents outdated styles from being applied and maintains the integrity of the user interface.