Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds ARM64 support to VS Code Snap packages by updating the build infrastructure, snapcraft configuration, and Azure CI/CD pipelines. The changes address long-standing feature requests (#125120, #269552) for ARM64 snap packages on Linux systems.
Changes:
- Updated snapcraft.yaml to support multi-architecture builds (x64 and arm64) and upgraded from Ubuntu 20.04 (core20) to 24.04 (core24) base
- Modified build scripts to generate architecture-specific snapcraft configurations with appropriate multiarch library paths
- Extended Azure pipeline to build and publish ARM64 snap packages alongside existing x64 packages
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| resources/linux/snap/snapcraft.yaml | Added architecture template variables, upgraded to core24 base, updated dependencies and library paths for multiarch support |
| build/gulpfile.vscode.linux.ts | Added BUILD_ARCHITECTURE and DEB_ARCHITECTURE template variable replacements for architecture-specific snap builds |
| build/azure-pipelines/product-build.yml | Propagated VSCODE_BUILD_LINUX_SNAP parameter to arm64 build job |
| build/azure-pipelines/linux/steps/product-build-linux-compile.yml | Extended snap build condition to include arm64 architecture and updated docker image reference to be architecture-specific |
dmitrivMS
added
linux
dmitrivMS
changed the title
dmitrivMS
changed the title
dmitrivMS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93046
Fixes #117685
Fixes #125120
Fixes #241174
Fixes #241636
Fixes #269552
Changes
Enabled building Snap package for
arm64.Upgraded Snap to
core22base.Register VS Code with
update-alternatives.