Skip to content

fix: include error handling in inline chat session overlay logic#298651

Merged
jrieken merged 1 commit intomainfrom
joh/latin-puffin
Mar 2, 2026
Merged

fix: include error handling in inline chat session overlay logic#298651
jrieken merged 1 commit intomainfrom
joh/latin-puffin

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Mar 2, 2026

re #298647

Copilot AI review requested due to automatic review settings March 2, 2026 07:44
@jrieken jrieken enabled auto-merge (squash) March 2, 2026 07:44
@jrieken jrieken self-assigned this Mar 2, 2026
@vs-code-engineering vs-code-engineering bot added this to the March 2026 milestone Mar 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures inline chat failures are surfaced to the user when inlineChat.renderMode = hover, where the main inline chat zone widget is intentionally hidden and error UI could previously disappear.

Changes:

  • Keep the hover-mode session overlay visible when the last inline chat request completed with an error (errorDetails present).

@jrieken jrieken merged commit f69012e into main Mar 2, 2026
24 checks passed
@jrieken jrieken deleted the joh/latin-puffin branch March 2, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants