Add more logging to sanity test runner#298664
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional diagnostic logging to the sanity test runner to help identify the root cause of intermittent test failures. It captures the Mocha Runner instance and attaches per-test event listeners.
Changes:
- Captures the
mocha.run()return value asrunnerand logs the failure count and exit code in the done callback. - Attaches three Mocha runner event listeners to log each test's start, pass, and fail (with error message).
bpasero
approved these changes
Mar 2, 2026
DonJayamanne
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to identity root cause of some strange failures.