Fix background color handling in terminal editor#298688
Merged
mrleemurray merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the background color handling for terminals opened in the editor tab context. The goal is visual consistency by using editor.background instead of terminal.background (or editorPane.background) when a terminal is in an editor.
Changes:
- Reorders
getBackgroundColor()inTerminalInstanceColorProviderto checkTerminalLocation.Editorfirst, returningeditorBackgroundbefore anyTERMINAL_BACKGROUND_COLORcheck. - Updates the
.terminal-editor .terminal-wrapperCSS rule to use--vscode-editor-backgrounddirectly, removing the previousvar(--vscode-terminal-background, var(--vscode-editorPane-background))pattern.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
terminalInstance.ts |
Moves editor-location check before TERMINAL_BACKGROUND_COLOR, so editor terminals always use editor.background |
terminal.css |
Replaces fallback CSS variable chain with a direct --vscode-editor-background reference for .terminal-editor .terminal-wrapper |
dmitrivMS
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the background color handling in the terminal editor to use the editor's background color instead of the terminal's background color. This change improves visual consistency within the editor environment.