weight and maintain specific order for foundational tips#298745
Merged
meganrogge merged 7 commits intomainfrom Mar 2, 2026
Merged
weight and maintain specific order for foundational tips#298745meganrogge merged 7 commits intomainfrom
meganrogge merged 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Chat Tip system to deliver a more coherent onboarding flow by introducing catalog-driven tiers (Foundational vs QoL) and priority-based ordering, while preserving stable rerender behavior with a special-case preemption for the “switch to auto” tip.
Changes:
- Introduces
ChatTipTierandprioritymetadata in the tip catalog to control ordering. - Updates
ChatTipServiceselection/navigation to prefer eligible Foundational tips (priority order) before QoL tips (randomized when only QoL remains). - Adds/updates tests to validate ordering, navigation behavior, and QoL randomization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chatTipCatalog.ts |
Adds ChatTipTier + priority and annotates all tips with tiering metadata. |
src/vs/workbench/contrib/chat/browser/chatTipService.ts |
Refactors tip selection to use tier/priority ordering and adds stable rerender preemption behavior for tip.switchToAuto. |
src/vs/workbench/contrib/chat/test/browser/chatTipService.test.ts |
Expands coverage for tier ordering, navigation ordering, and QoL randomization behavior. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joshspicer
approved these changes
Mar 2, 2026
DonJayamanne
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #297018
tier+priority.switchToAuto->agentMode->planMode->createAgent->createSkill->createInstruction.gpt-4.1becomes active andswitchToAutois eligible, it now preempts and shows immediately.demo-weighted.mov