Skip to content

weight and maintain specific order for foundational tips#298745

Merged
meganrogge merged 7 commits intomainfrom
merogge/weight-tips
Mar 2, 2026
Merged

weight and maintain specific order for foundational tips#298745
meganrogge merged 7 commits intomainfrom
merogge/weight-tips

Conversation

@meganrogge
Copy link
Collaborator

@meganrogge meganrogge commented Mar 2, 2026

fix #297018

  • Tip ordering is catalog-driven with tier + priority.
  • Selection order is:
    1. eligible foundational tips (sorted by priority)
    2. then QoL tips
  • Current foundational priority is:
    switchToAuto -> agentMode -> planMode -> createAgent -> createSkill -> createInstruction.
  • Stable rerender still preserves current tip, except:
    • if gpt-4.1 becomes active and switchToAuto is eligible, it now preempts and shows immediately.
demo-weighted.mov

Copilot AI review requested due to automatic review settings March 2, 2026 17:04
@meganrogge meganrogge self-assigned this Mar 2, 2026
@meganrogge meganrogge added this to the March 2026 milestone Mar 2, 2026
@meganrogge meganrogge enabled auto-merge (squash) March 2, 2026 17:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Chat Tip system to deliver a more coherent onboarding flow by introducing catalog-driven tiers (Foundational vs QoL) and priority-based ordering, while preserving stable rerender behavior with a special-case preemption for the “switch to auto” tip.

Changes:

  • Introduces ChatTipTier and priority metadata in the tip catalog to control ordering.
  • Updates ChatTipService selection/navigation to prefer eligible Foundational tips (priority order) before QoL tips (randomized when only QoL remains).
  • Adds/updates tests to validate ordering, navigation behavior, and QoL randomization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/chat/browser/chatTipCatalog.ts Adds ChatTipTier + priority and annotates all tips with tiering metadata.
src/vs/workbench/contrib/chat/browser/chatTipService.ts Refactors tip selection to use tier/priority ordering and adds stable rerender preemption behavior for tip.switchToAuto.
src/vs/workbench/contrib/chat/test/browser/chatTipService.test.ts Expands coverage for tier ordering, navigation ordering, and QoL randomization behavior.

@meganrogge meganrogge merged commit d356f40 into main Mar 2, 2026
20 checks passed
@meganrogge meganrogge deleted the merogge/weight-tips branch March 2, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weight getting started tips vs QOL ones

3 participants