Skip to content

Hooks GA#298803

Open
pwang347 wants to merge 1 commit intomainfrom
pawang/hooksGA
Open

Hooks GA#298803
pwang347 wants to merge 1 commit intomainfrom
pawang/hooksGA

Conversation

@pwang347
Copy link
Member

@pwang347 pwang347 commented Mar 2, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 2, 2026 20:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes Chat “hooks” to GA by removing the “preview” designation and the preview-feature gating behavior from the hooks-related settings in the chat configuration contribution.

Changes:

  • Removed the preview tag from the hooks-related settings so they no longer appear as preview features.
  • Removed the account-policy-based override that disabled chat.useChatHooks when chat_preview_features_enabled === false.

@yardenshoham
Copy link

Before making it GA, I suggest changing chat.useClaudeHooks default to true. All the docs point to ~/.claude/settings.json as the only place to put user-specified hooks. When you actually try to use them in VS Code as well as the chat app, the hooks are read and listed as loaded (even in the diagnostics view), but they never get executed unless you set this setting to true. There is no place in the documentation that tells you that you need to set this to true if you want to use user-specified hooks.

The only reason I was able to understand this is because I spent the last hour investigating both codebases, VS Code and the chat extension.

@yardenshoham
Copy link

One more thing I would do before making it GA is fix #297575. When you try to configure a UserPromptSubmit with other hooks this error reproduces frequently.

@pwang347
Copy link
Member Author

pwang347 commented Mar 4, 2026

Hi @yardenshoham, thanks for the comments.

I suggest changing chat.useClaudeHooks default to true

We don't currently intend to do this because there are still several incompatibilities that can cause potential issues when hooks are executed (which is bad if people are expecting to leverage hooks for security/enterprise reasons). This needs to be opt-in until we get stronger signals that people are aware of the compatibility differences and are able to adjust accordingly. We are also planning to improve the documentation for this scenario since it's a bit lacking as you found.

One more thing I would do before making it GA is fix #297575. When you try to configure a UserPromptSubmit with other hooks this error reproduces frequently.

This is fixed on latest Insiders and in the Stable version that will release this week. Let me know if you can still reproduce it once the update is out!

@yardenshoham
Copy link

Thank you for the insightful comment. Are you sure you want to mark this as generally available, seeing as the functionality to create user-scoped hooks does not work? Why not do the same thing that was done with skills, where there was at least a way to configure user scope skills? At this point, it's better to remove from the documentation what is currently documented and just say that there is only support for workspace scoped hooks

@pwang347
Copy link
Member Author

pwang347 commented Mar 4, 2026

@yardenshoham User-scoped hooks are technically supported already, but you would need to add a manual entry to chat.hookFilesLocations. I expect to see a default folder for this soon (most likely ~/.copilot/hooks) but since Copilot CLI isn't supporting that yet we're waiting to see what the right path should be here. Hope this helps!

@pwang347 pwang347 modified the milestones: 1.111.0, On Deck Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants