Conversation
There was a problem hiding this comment.
Pull request overview
This PR promotes Chat “hooks” to GA by removing the “preview” designation and the preview-feature gating behavior from the hooks-related settings in the chat configuration contribution.
Changes:
- Removed the
previewtag from the hooks-related settings so they no longer appear as preview features. - Removed the account-policy-based override that disabled
chat.useChatHookswhenchat_preview_features_enabled === false.
|
Before making it GA, I suggest changing The only reason I was able to understand this is because I spent the last hour investigating both codebases, VS Code and the chat extension. |
|
One more thing I would do before making it GA is fix #297575. When you try to configure a UserPromptSubmit with other hooks this error reproduces frequently. |
|
Hi @yardenshoham, thanks for the comments.
We don't currently intend to do this because there are still several incompatibilities that can cause potential issues when hooks are executed (which is bad if people are expecting to leverage hooks for security/enterprise reasons). This needs to be opt-in until we get stronger signals that people are aware of the compatibility differences and are able to adjust accordingly. We are also planning to improve the documentation for this scenario since it's a bit lacking as you found.
This is fixed on latest Insiders and in the Stable version that will release this week. Let me know if you can still reproduce it once the update is out! |
|
Thank you for the insightful comment. Are you sure you want to mark this as generally available, seeing as the functionality to create user-scoped hooks does not work? Why not do the same thing that was done with skills, where there was at least a way to configure user scope skills? At this point, it's better to remove from the documentation what is currently documented and just say that there is only support for workspace scoped hooks |
|
@yardenshoham User-scoped hooks are technically supported already, but you would need to add a manual entry to |
No description provided.