Check language model session target#298862
Merged
DonJayamanne merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where fresh VS Code Insiders instances could not process chat responses after signing in. The root cause was that getDefaultLanguageModel() could inadvertently select a model with targetChatSessionType set (e.g., a background/CLI-targeted model) as the "default" model, even though such models are scoped exclusively to specific session types and should not be used for general chat.
Changes:
- The
getDefaultLanguageModel()method now additionally requires that a candidate default model has notargetChatSessionTypeset, preventing session-specific models from being selected as the general default.
dmitrivMS
approved these changes
Mar 3, 2026
TylerLeonhardt
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297337