Skip to content

support multiple questions coming in for chat#299006

Merged
meganrogge merged 3 commits intomainfrom
merogge/question-multi
Mar 3, 2026
Merged

support multiple questions coming in for chat#299006
meganrogge merged 3 commits intomainfrom
merogge/question-multi

Conversation

@meganrogge
Copy link
Collaborator

fix #297408

Singleton carousel widget → DisposableMap of carousels keyed by resolveId. New ones append instead of replacing. Clearing targets a specific carousel by resolveId. CSS stacks them vertically with a gap.

multi-question.mov

Copilot AI review requested due to automatic review settings March 3, 2026 16:54
@meganrogge meganrogge self-assigned this Mar 3, 2026
@meganrogge meganrogge added this to the March 2026 milestone Mar 3, 2026
@meganrogge meganrogge enabled auto-merge (squash) March 3, 2026 16:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the chat input’s question-carousel rendering so multiple concurrent ask_question flows can be shown and answered without newer carousels replacing (and effectively canceling) earlier ones.

Changes:

  • Replace the single question-carousel instance with a DisposableMap keyed by resolveId, allowing multiple carousels to coexist.
  • Update clearing logic to remove a specific carousel (by resolveId) or all carousels for a given responseId.
  • Adjust CSS so multiple carousels stack vertically with spacing.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Switches to multi-carousel tracking and updates render/clear/focus logic accordingly.
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts Clears only the submitted carousel from the input, instead of clearing all.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css Uses flex column layout + gap to stack multiple carousels in the input area.

meganrogge and others added 2 commits March 3, 2026 12:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@meganrogge meganrogge merged commit 29d5097 into main Mar 3, 2026
20 of 21 checks passed
@meganrogge meganrogge deleted the merogge/question-multi branch March 3, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel ask_question calls will cancel the first call

3 participants