support multiple questions coming in for chat#299006
Merged
meganrogge merged 3 commits intomainfrom Mar 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat input’s question-carousel rendering so multiple concurrent ask_question flows can be shown and answered without newer carousels replacing (and effectively canceling) earlier ones.
Changes:
- Replace the single question-carousel instance with a
DisposableMapkeyed byresolveId, allowing multiple carousels to coexist. - Update clearing logic to remove a specific carousel (by
resolveId) or all carousels for a givenresponseId. - Adjust CSS so multiple carousels stack vertically with spacing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Switches to multi-carousel tracking and updates render/clear/focus logic accordingly. |
| src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts | Clears only the submitted carousel from the input, instead of clearing all. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css | Uses flex column layout + gap to stack multiple carousels in the input area. |
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roblourens
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #297408
Singleton carousel widget →
DisposableMapof carousels keyed byresolveId. New ones append instead of replacing. Clearing targets a specific carousel byresolveId. CSS stacks them vertically with a gap.multi-question.mov