refactor AIAdatper out of ai telemetry appender#2991
Merged
isidorn merged 1 commit intomicrosoft:masterfrom Feb 14, 2016
sofianhn:master
Merged
refactor AIAdatper out of ai telemetry appender#2991isidorn merged 1 commit intomicrosoft:masterfrom sofianhn:master
isidorn merged 1 commit intomicrosoft:masterfrom
sofianhn:master
Conversation
isidorn
added a commit
that referenced
this pull request
Feb 14, 2016
refactor AIAdatper out of ai telemetry appender
Collaborator
|
How can I say 'no' to something that has tests 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the application insight wrapper logic outside of the
nodeAppInsightsTelemetryAppender.App Insights requires special logic to make sure that the client is setup with the correct properties, as well as making sure we disable all non-required collections.
With this change,
AIAdapteris now available in base/node as dependency to be used anywhere in the codebase. Taking this to base is intensionally not to have any tie between Application Insights and the telemetry service as they are not coupled from architecture perspective.