feat: enhance chat session option updates#299109
Merged
DonJayamanne merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
osortega
previously approved these changes
Mar 4, 2026
DonJayamanne
force-pushed
the
don/variable-quokka
branch
from
0245990 to
b8b2d0c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines how chat session “agent” option updates are propagated from the chat input when the current chat mode changes, aiming to avoid unnecessary extension notifications. It also adds a sample custom agent definition under .github/agents for use in repository workflows/testing.
Changes:
- Add conditional logic to only call
notifySessionOptionsChangewhen the “agent” session option appears to require an update. - Introduce
.github/agents/test.agent.mdas a custom agent template/example.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Adds a needsUpdate check before notifying extensions about the agent session option change. |
| .github/agents/test.agent.md | Adds a sample custom agent definition (YAML front matter + instructions). |
osortega
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.