Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts #298950, which had introduced improvements to session hover title rendering (using renderAsPlaintext on the markdown label for a simple hover) and persistence. The revert rolls back the rename from disableHover → useSimpleHover and removes the plaintext hover rendering that was added in that PR, restoring the original early-return behavior when hover is disabled.
Changes:
- Renames the option
useSimpleHoverback todisableHoverin all relevant interfaces and usages. - Removes the plaintext-markdown hover rendering logic that was introduced in #298950, restoring the simple early-return when hover is disabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
agentSessionsViewer.ts |
Reverts IAgentSessionRendererOptions.useSimpleHover → disableHover; restores renderHover to return early instead of showing a plaintext hover |
agentSessionsControl.ts |
Reverts IAgentSessionsControlOptions.useSimpleHover → disableHover |
sessionsViewPane.ts |
Reverts usage site: useSimpleHover: true → disableHover: true |
agentSessionsViewer.fixture.ts |
Reverts test fixture: useSimpleHover: true → disableHover: true |
jrieken
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #298950