Skip to content

Support multi line terminal command approvals with ellipsis and aligned approve button#299184

Merged
benibenj merged 2 commits intomainfrom
benibenj/printed-grasshopper
Mar 4, 2026
Merged

Support multi line terminal command approvals with ellipsis and aligned approve button#299184
benibenj merged 2 commits intomainfrom
benibenj/printed-grasshopper

Conversation

@benibenj
Copy link
Contributor

@benibenj benibenj commented Mar 4, 2026

Copilot Generated Description: Implement support for multi-line terminal command approvals, allowing up to three lines to be displayed with an ellipsis for overflow. Adjust the approval row height dynamically based on the number of lines. Update CSS for alignment and styling of the approval button. Add new test fixtures for various approval scenarios.

Copilot AI review requested due to automatic review settings March 4, 2026 12:08
@benibenj benibenj enabled auto-merge March 4, 2026 12:08
@benibenj benibenj self-assigned this Mar 4, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.111.0 milestone Mar 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for displaying multi-line terminal command approval labels (up to 3 lines with ellipsis) and adjusts list row heights + styling so the approve button aligns with the truncated label content.

Changes:

  • Compute dynamic approval-row height based on the number of command lines (capped at 3).
  • Render approval labels as multiple single-line code blocks with ellipsis + full hover content.
  • Add new component fixtures for 1–4 lines and long multi-line approval labels; tweak CSS alignment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/vs/workbench/test/browser/componentFixtures/agentSessionsViewer.fixture.ts Adds fixtures covering 1–4 line and long multi-line approval label scenarios.
src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css Updates approval-row alignment and removes fixed height to allow dynamic sizing.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts Implements multi-line truncation + hover and computes dynamic row height for list virtualization.

You can also share your feedback on Copilot code review. Take the survey.

…onsViewer.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@benibenj benibenj merged commit 907cb9c into main Mar 4, 2026
20 checks passed
@benibenj benibenj deleted the benibenj/printed-grasshopper branch March 4, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants