Support multi line terminal command approvals with ellipsis and aligned approve button#299184
Merged
Support multi line terminal command approvals with ellipsis and aligned approve button#299184
Conversation
…ed approve button
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for displaying multi-line terminal command approval labels (up to 3 lines with ellipsis) and adjusts list row heights + styling so the approve button aligns with the truncated label content.
Changes:
- Compute dynamic approval-row height based on the number of command lines (capped at 3).
- Render approval labels as multiple single-line code blocks with ellipsis + full hover content.
- Add new component fixtures for 1–4 lines and long multi-line approval labels; tweak CSS alignment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/agentSessionsViewer.fixture.ts | Adds fixtures covering 1–4 line and long multi-line approval label scenarios. |
| src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css | Updates approval-row alignment and removes fixed height to allow dynamic sizing. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts | Implements multi-line truncation + hover and computes dynamic row height for list virtualization. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts
Show resolved
Hide resolved
src/vs/workbench/test/browser/componentFixtures/agentSessionsViewer.fixture.ts
Show resolved
Hide resolved
src/vs/workbench/test/browser/componentFixtures/agentSessionsViewer.fixture.ts
Show resolved
Hide resolved
…onsViewer.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lszomoru
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Implement support for multi-line terminal command approvals, allowing up to three lines to be displayed with an ellipsis for overflow. Adjust the approval row height dynamically based on the number of lines. Update CSS for alignment and styling of the approval button. Add new test fixtures for various approval scenarios.