Skip to content

Sessions - hide the apply change action#299188

Merged
lszomoru merged 1 commit intomainfrom
lszomoru/yucky-lizard
Mar 4, 2026
Merged

Sessions - hide the apply change action#299188
lszomoru merged 1 commit intomainfrom
lszomoru/yucky-lizard

Conversation

@lszomoru
Copy link
Member

@lszomoru lszomoru commented Mar 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 4, 2026 12:42
@lszomoru lszomoru enabled auto-merge (squash) March 4, 2026 12:42
@lszomoru lszomoru self-assigned this Mar 4, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.111.0 milestone Mar 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hides the “Apply Changes to Parent Repository” action from the Agent Sessions UI by making its menu visibility condition always evaluate to false.

Changes:

  • Updated the action’s menu when clause to include ContextKeyExpr.false(), preventing it from appearing in the “Apply Actions” submenu.
Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/applyCommitsToParentRepo/browser/applyChangesToParentRepo.ts:74

  • ContextKeyExpr.and(ContextKeyExpr.false(), …) permanently hides the menu item but still includes other context keys, which will continue to be collected for menu eventing/refresh even though the expression can never be true. If the intent is to hard-disable this entry, prefer when: ContextKeyExpr.false() (no extra keys) or remove the menu contribution so the intent is clearer.
					when: ContextKeyExpr.and(
						ContextKeyExpr.false(),
						IsSessionsWindowContext,
						hasWorktreeAndRepositoryContextKey
					),

@lszomoru lszomoru merged commit c078240 into main Mar 4, 2026
24 checks passed
@lszomoru lszomoru deleted the lszomoru/yucky-lizard branch March 4, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants