Skip to content

Add components for AI Customization shortcuts widget#299206

Merged
benibenj merged 1 commit intomainfrom
benibenj/musical-flyingfish
Mar 4, 2026
Merged

Add components for AI Customization shortcuts widget#299206
benibenj merged 1 commit intomainfrom
benibenj/musical-flyingfish

Conversation

@benibenj
Copy link
Contributor

@benibenj benibenj commented Mar 4, 2026

Copilot Generated Description: Introduce components for the AI Customization shortcuts widget, including a new toolbar and related functionality for managing customization items. The changes include the creation of a new widget class and updates to existing interfaces to support the new features.

Copilot AI review requested due to automatic review settings March 4, 2026 15:18
@benibenj benibenj enabled auto-merge March 4, 2026 15:18
@benibenj benibenj self-assigned this Mar 4, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.111.0 milestone Mar 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a dedicated AI Customization shortcuts widget for the Agent Sessions window, refactoring the Sessions view to use the new widget and adding a component fixture for screenshot coverage.

Changes:

  • Extracts the AI Customization toolbar UI/behavior into a new AICustomizationShortcutsWidget.
  • Updates sessionsViewPane to instantiate the new widget and removes the inline toolbar implementation.
  • Adds a new themed component fixture to render the widget in multiple states (expanded/collapsed, with MCP servers, with counts).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/vs/sessions/contrib/sessions/test/browser/aiCustomizationShortcutsWidget.fixture.ts Adds screenshot component fixtures for the new widget with mocked services and menu/view-item plumbing.
src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts Replaces inline customization toolbar code with AICustomizationShortcutsWidget.
src/vs/sessions/contrib/sessions/browser/media/customizationsToolbar.css Adjusts customization toolbar CSS selectors (no longer nested under .agent-sessions-viewpane).
src/vs/sessions/contrib/sessions/browser/customizationsToolbar.contribution.ts Exports customization item config/list and view item class for reuse (fixture); also exports the contribution class.
src/vs/sessions/contrib/sessions/browser/aiCustomizationShortcutsWidget.ts New widget encapsulating the customization shortcuts header + toolbar + collapse/count logic.
Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/sessions/browser/customizationsToolbar.contribution.ts:206

  • CustomizationsToolbarContribution is now exported, but it doesn’t appear to be imported/used outside this module. Exporting it increases the module’s public surface area without a clear need.

Consider keeping this class non-exported unless there’s a concrete external consumer (the fixture only needs CUSTOMIZATION_ITEMS and CustomizationLinkViewItem).

export class CustomizationsToolbarContribution extends Disposable implements IWorkbenchContribution {

	static readonly ID = 'workbench.contrib.sessionsCustomizationsToolbar';

	constructor(

You can also share your feedback on Copilot code review. Take the survey.

@benibenj benibenj merged commit e933711 into main Mar 4, 2026
24 checks passed
@benibenj benibenj deleted the benibenj/musical-flyingfish branch March 4, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants