Final port of misc 2026 theme styles - refine color theme styles for improved UI consistency#299237
Merged
mrleemurray merged 5 commits intomainfrom Mar 4, 2026
Merged
Conversation
…better maintainability Co-authored-by: Copilot <copilot@github.com>
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
@jriekenMatched files:
@rzhao271Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Ports remaining theme-specific CSS overrides from the theme-2026 extension into core workbench/component styles, while adjusting theme color tokens to improve consistency (notably around borders and secondary text) and removing now-unneeded extension CSS contributions.
Changes:
- Removes the
theme-2026extension’s injectedstyles.css(and relatedcssproposal usage) after moving key styling into product CSS. - Updates multiple core CSS files to use standard theme tokens (
editorWidget.*,descriptionForeground, size tokens) for more consistent rendering across themes. - Refines
theme-2026light/dark JSON tokens (e.g., tab borders, sticky scroll border, inline chat border, checkbox foreground) and drops explicitcontrastBorderoverrides.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts | Removes inline count-badge theming styles and trims unused color imports. |
| src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css | Applies descriptionForeground to the settings result count widget via CSS. |
| src/vs/workbench/contrib/notebook/browser/media/notebook.css | Aligns notebook cell toolbar background with editorWidget.background. |
| src/vs/workbench/contrib/chat/browser/chatEditing/media/chatEditorController.css | Switches border token from contrastBorder to editorWidget.border. |
| src/vs/workbench/contrib/chat/browser/chatEditing/media/chatEditingEditorOverlay.css | Switches border token from contrastBorder to editorWidget.border. |
| src/vs/platform/quickinput/browser/media/quickInput.css | Styles quick input separator using size tokens and descriptionForeground. |
| src/vs/editor/browser/viewParts/minimap/minimap.css | Sets a default minimap canvas opacity in core CSS. |
| src/vs/base/browser/ui/inputbox/inputBox.css | Forces inputbox action icons to follow icon.foreground. |
| extensions/theme-2026/themes/styles.css | Removes extension-provided global CSS overrides (file deleted). |
| extensions/theme-2026/themes/2026-light.json | Updates theme tokens (tabs border, sticky scroll border, inline chat border, checkbox foreground) and removes contrastBorder. |
| extensions/theme-2026/themes/2026-dark.json | Updates theme tokens (tabs border, sticky scroll border, inline chat border, checkbox foreground, command center active background) and removes contrastBorder. |
| extensions/theme-2026/package.json | Removes enabledApiProposals: ["css"] and the contributes.css entry now that styles are ported. |
3 tasks
dmitrivMS
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the color theme styles and clean up unused CSS for better maintainability and consistency across the UI components. Adjustments include removing contrast borders and refining tab border styles.