sessions - clarify instructions around compiling and testing#299255
Merged
sessions - clarify instructions around compiling and testing#299255
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates contributor-facing documentation to make TypeScript compilation and test-running guidance clearer for the agent sessions area and for Copilot instruction users.
Changes:
- Updates the sessions skill doc to point to
scripts/test.sh/scripts\test.batfor running unit tests (with--grepfiltering). - Adds an explicit warning in the sessions skill doc to avoid running
tscdirectly for validation. - Updates Copilot instructions to use
npm run gulp compile-extensions(instead ofgulp compile-extensions) when validating built-in extension changes without the build task.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/skills/sessions/SKILL.md | Clarifies how to run unit tests and adds guidance about TypeScript validation workflow. |
| .github/copilot-instructions.md | Adjusts extension compilation guidance to use the repo’s npm run gulp script wrapper. |
Comments suppressed due to low confidence (2)
.github/skills/sessions/SKILL.md:275
- List item 3 is the only one in this section without ending punctuation, which makes the list inconsistent with items 1–2. Consider adding a trailing period (and optionally a semicolon-free parenthetical) to match the surrounding style.
3. Use `scripts/test.sh` (or `scripts\test.bat` on Windows) for unit tests (add `--grep <pattern>` to filter tests)
.github/skills/sessions/SKILL.md:277
- This reads as a run-on sentence and is missing punctuation/capitalization. Consider rewriting as "Important: Do not run
tscto check for TypeScript errors; always use the methods above to validate TypeScript changes insrc/vs/**."
**Important** do not run `tsc` to check for TypeScript errors always use above methods to validate TypeScript changes in `src/vs/**`.
dmitrivMS
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.