Merged
Conversation
- Border radius matches chat input (cornerRadius-large) - Background uses panel background - Remove colon prefix from option descriptions - Option list items use cornerRadius-medium - Footer padding: 8px left, 16px right - 12px gap between number and labels - Freeform row aligned with preset options - Close button vertically centered in titlebar - Checkboxes center-aligned in list items - has-description class for title+description items - Number elements use consistent width - Focus outline consistent across all list items - Tighter gap between presets and custom answer - Summary Q/A always on separate rows - Hide submit icon when carousel is open (show stop only) - Show submit when user types to steer
Contributor
There was a problem hiding this comment.
Pull request overview
UI/behavior polish for the chat question carousel widget, aligning styling with current VS Code tokens and improving navigation/submit affordances when a carousel is present.
Changes:
- Updates carousel styling (radius, padding, footer layout, option alignment) and adds a
has-descriptionlayout variant. - Refactors multi-question navigation footer (persistent footer with step indicator, submit hint, and submit button shown only on last step).
- Adjusts execute/submit action visibility so the Send (submit) icon is hidden while a carousel is open unless the user has typed input.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css | Visual/layout updates for carousel container, list items, footer, and summary rendering. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts | Refactors carousel header/footer rendering and keyboard handling; adjusts summary markup to Q/A rows. |
| src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts | Context-key conditions to hide/show submit icon based on carousel presence and input text. |
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css:444
- The summary markup now renders answers/unanswered states using
.chat-question-summary-answerand.chat-question-summary-unanswered, but the CSS still only styles the old.chat-question-summary-answer-title/.chat-question-summary-answer-descselectors. Update the summary styles to target the new class names (and consider removing the now-dead selectors) so the summary text keeps the intended emphasis/colors.
.chat-question-summary-item {
display: flex;
flex-direction: column;
gap: 0;
font-size: var(--vscode-chat-font-size-body-s);
}
.chat-question-summary-label {
color: var(--vscode-descriptionForeground);
word-wrap: break-word;
overflow-wrap: break-word;
}
.chat-question-summary-answer-title {
color: var(--vscode-foreground);
font-weight: 600;
word-wrap: break-word;
overflow-wrap: break-word;
}
.chat-question-summary-answer-desc {
color: var(--vscode-foreground);
word-wrap: break-word;
overflow-wrap: break-word;
}
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css
Show resolved
Hide resolved
Update test selectors and structure to match current DOM: - Remove .chat-question-carousel-nav assertion (element no longer exists) - Update markdown/message tests to use .chat-question-title - Fix nav button tests to use multi-question carousels with .chat-question-nav-arrow - Fix submit button test to use multi-question carousel
meganrogge
approved these changes
Mar 4, 2026
Collaborator
meganrogge
left a comment
There was a problem hiding this comment.
Works well for me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual polish and behavior fixes for the question carousel widget.
@meganrogge
Changes
Styling
cornerRadius-large)cornerRadius-mediummin-width/text-align)Layout
has-descriptionclass distinguishes items with title + description from single-line itemsContent
:prefix from option descriptionsBehavior
Outstanding issues not yet fixed by this PR