Action widget: hover background for open pickers#299301
Merged
daviddossett merged 4 commits intomainfrom Mar 5, 2026
Merged
Conversation
…ckers - Remove horizontal padding from action widget, inset list rows instead so separators span edge-to-edge - Fire onDidChangeVisibility in ActionWidgetDropdown so aria-expanded is set correctly for all picker types - Apply toolbar hover background to picker buttons while their dropdown is open
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the chat “action widget” dropdown UI/UX by making separators span the full widget width and ensuring picker trigger buttons remain visually “active” while their dropdown is open (via correct aria-expanded updates).
Changes:
- Adjust action widget CSS so list rows are inset while separators remain full-width.
- Fix
ActionWidgetDropdown.show()/hide flow to correctly fireonDidChangeVisibility(enablingaria-expanded="true"while open). - Add chat toolbar styling keyed off
[aria-expanded="true"]to persist the hover background; tweak model picker dropdown min width.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Styles open picker triggers using [aria-expanded="true"] to keep the hover background visible. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Reduces model picker dropdown minimum width. |
| src/vs/platform/actionWidget/browser/actionWidgetDropdown.ts | Calls super.show() and ensures hide() runs on dropdown close so visibility events (and aria-expanded) stay in sync. |
| src/vs/platform/actionWidget/browser/actionWidget.css | Insets list rows while keeping separators full-width; aligns action bar and filter padding with new layout. |
…idget-separators-hover
daviddossett
changed the title
justschen
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onDidChangeVisibilityinActionWidgetDropdownsoaria-expandedis set correctly for all picker types