Don't steal focus for readonly editors#299303
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Agent Sessions agent-feedback editor overlay behavior to avoid unintended focus changes while the feedback input widget is visible, and introduces an explicit shortcut to focus the feedback input.
Changes:
- Adds an explicit Ctrl+I / Cmd+I path to focus the feedback input while the widget is visible.
- Changes when “type-to-focus” auto-focus happens (now gated by
EditorOption.readOnly). - Adds a
focusInput()helper method on the editor contribution.
You can also share your feedback on Copilot code review. Take the survey.
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts
Show resolved
Hide resolved
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts
Show resolved
Hide resolved
Yoyokrazy
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Prevent the editor from automatically focusing the feedback input when the document is readonly. Introduce explicit focus control using Ctrl+I or Cmd+I for the feedback input.