Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves terminal tracking in the Agent Sessions window by attempting to “adopt” terminals created outside the contribution (eg restored/external terminals) into the active session based on their initial working directory, and by hiding terminals that cannot be related to the active session. It also adds a command for dumping terminal tracking state for debugging.
Changes:
- Adopt (or hide) externally-created/restored terminals by comparing their initial cwd against the active session context.
- Add a debug action/command to dump tracked vs untracked terminals.
- Extend the sessions terminal contribution tests to cover adoption/hiding behavior for external terminals.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/terminal/browser/sessionsTerminalContribution.ts | Adds external terminal adoption logic, introduces a dump-tracking command, and adjusts creation handling to avoid immediately backgrounding untracked terminals. |
| src/vs/sessions/contrib/terminal/test/browser/sessionsTerminalContribution.test.ts | Adds terminal instance stubs that support getInitialCwd() and new tests validating adoption/hiding behavior. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/sessions/contrib/terminal/browser/sessionsTerminalContribution.ts
Show resolved
Hide resolved
src/vs/sessions/contrib/terminal/browser/sessionsTerminalContribution.ts
Show resolved
Hide resolved
src/vs/sessions/contrib/terminal/browser/sessionsTerminalContribution.ts
Show resolved
Hide resolved
Yoyokrazy
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Improve tracking of externally created terminals by associating them with the active session based on their current working directory. Add functionality to hide terminals that do not match the active session's context. Include a new action to dump terminal tracking information for debugging purposes.