Skip to content

permissions picker warnings and improved hover#299331

Merged
justschen merged 2 commits intomainfrom
justin/solosis
Mar 5, 2026
Merged

permissions picker warnings and improved hover#299331
justschen merged 2 commits intomainfrom
justin/solosis

Conversation

@justschen
Copy link
Collaborator

  • warning the first time you switch to auto approve or auto pilot
  • if global auto approve is on, you don't reset your permission per session
  • better permission picker.
Screenshot 2026-03-04 at 4 18 38 PM Screenshot 2026-03-04 at 4 18 46 PM

Copilot AI review requested due to automatic review settings March 5, 2026 00:19
@justschen justschen enabled auto-merge (squash) March 5, 2026 00:19
@vs-code-engineering vs-code-engineering bot added this to the 1.111.0 milestone Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the chat permission picker UX by adding first-time warnings for elevated permission modes, refining option presentation, and aligning session permission reset behavior with the global auto-approve setting.

Changes:

  • Add warning prompts when switching to Bypass Approvals or Autopilot for the first time per window session.
  • Preserve per-session permission level across new sessions when global auto-approve is enabled.
  • Add an ActionList option to render item descriptions below the title and apply it to the permission picker.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/input/permissionPickerActionItem.ts Adds first-time warnings + richer option descriptions and layout options for the permission picker.
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Changes when the permission level resets on new sessions based on global auto-approve.
src/vs/platform/actionWidget/browser/actionWidget.css Adds styling for “description below” list rendering.
src/vs/platform/actionWidget/browser/actionList.ts Introduces descriptionBelow list option and adjusts row height/classing accordingly.

You can also share your feedback on Copilot code review. Take the survey.

@justschen justschen merged commit 79af825 into main Mar 5, 2026
20 checks passed
@justschen justschen deleted the justin/solosis branch March 5, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants