Skip to content

Customizations: Adjust search bar height in layout methods for consistency across widgets#299333

Merged
joshspicer merged 1 commit intomainfrom
copilot-worktree-2026-03-04T22-33-52
Mar 5, 2026
Merged

Customizations: Adjust search bar height in layout methods for consistency across widgets#299333
joshspicer merged 1 commit intomainfrom
copilot-worktree-2026-03-04T22-33-52

Conversation

@joshspicer
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings March 5, 2026 00:35
@vs-code-engineering vs-code-engineering bot added this to the 1.111.0 milestone Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the AI Customization management list widgets’ layout calculations so the search row height is treated consistently across the different list widgets, aligning the UI sizing behavior.

Changes:

  • Updated list widget layout() calculations to use a 52px fallback search row height when offsetHeight is not available.
  • Changed the search/button row styling from margin to padding so the row’s spacing is included in its measured height.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts Updates layout fallback used when computing available list height under the search/button row.
src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts Updates layout fallback used when computing available list height under the search/button row.
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts Updates layout fallback used when computing available list height under the search/button row.
src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css Replaces margin with padding on the search/button row so spacing contributes to measured element height.

@joshspicer joshspicer merged commit efd8663 into main Mar 5, 2026
24 checks passed
@joshspicer joshspicer deleted the copilot-worktree-2026-03-04T22-33-52 branch March 5, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants