fix: Display chat session contributed models and ignore inline chat as they don't apply#299335
Merged
DonJayamanne merged 2 commits intomainfrom Mar 5, 2026
Merged
fix: Display chat session contributed models and ignore inline chat as they don't apply#299335DonJayamanne merged 2 commits intomainfrom
DonJayamanne merged 2 commits intomainfrom
Conversation
…s they don't apply
joshspicer
previously approved these changes
Mar 5, 2026
pwang347
approved these changes
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts chat model picker filtering so that models contributed for a specific chat session type are displayed for that session type, without applying additional UI-context filters.
Changes:
- Changes
filterModelsForSessionto return session-targeted models based only ontargetChatSessionTypeandisUserSelectable. - Leaves general (non-session-targeted) model filtering unchanged (still filters by mode + inline-chat compatibility).
src/vs/workbench/contrib/chat/browser/widget/input/chatModelSelectionLogic.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lramos15 /cc