fix: accept Azure DevOps Git URLs without .git suffix in plugin marketplace

[Copilot]

parseMarketplaceReference silently rejected Azure DevOps HTTPS clone URLs (https://dev.azure.com/org/project/_git/repo) because normalizeGitRepoPath required a .git suffix. Users had to manually append .git to the canonical URL provided by Azure DevOps.

Changes

• normalizeGitRepoPath: Removes the hard .git requirement. Path depth validation now strips .git only when present before checking for at least two segments. Uses a gitSuffix constant instead of the magic number -4 for maintainability.
• parseUriMarketplaceReference: Handles both forms using a gitSuffix constant:
  • cacheSegments strip .git when present
  • canonicalId always normalizes to include .git, so …/repo and …/repo.git deduplicate to the same entry
• Tests: Updated the test that expected HTTPS/SSH URLs without .git to be rejected; added tests for Azure DevOps-style URLs and cross-suffix deduplication. SCP-style (git@host:path) still requires .git.

Example — this now parses correctly:

https://dev.azure.com/org/project/_git/repo
→ canonicalId: git:dev.azure.com/org/project/_git/repo.git
→ cacheSegments: ['dev.azure.com', 'org', 'project', '_git', 'repo']

And deduplicates with https://dev.azure.com/org/project/_git/repo.git to a single entry.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR updates marketplace Git URL parsing to accept Azure DevOps (and general HTTPS/SSH) clone URLs that omit the .git suffix, while normalizing canonical IDs to include .git for deduplication.

Changes:

• Relaxes normalizeGitRepoPath by removing the hard .git requirement while still validating minimum path depth.
• Updates URI parsing to strip .git for cache segments but always include .git in canonicalId for deduplication.
• Updates/adds tests for Azure DevOps URLs and cross-suffix deduplication behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/vs/workbench/contrib/chat/common/plugins/pluginMarketplaceService.ts	Adjusts Git URL normalization and URI parsing to accept URLs without .git while keeping canonical IDs stable.
src/vs/workbench/contrib/chat/test/common/plugins/pluginMarketplaceService.test.ts	Updates/extends tests to cover non-.git URLs (including Azure DevOps) and deduplication.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

The .git suffix is handled via repeated string literals and the magic number -4. Consider introducing a single constant (e.g., const gitSuffix = '.git') and using gitSuffix.length in slice() calls. This reduces the risk of future inconsistencies and makes the intent clearer.

See below for a potential fix:

	const gitSuffix = '.git';
	const sanitizedAuthority = sanitizePathSegment(uri.authority.toLowerCase());
	const pathHasGitSuffix = normalizedPath.toLowerCase().endsWith(gitSuffix);
	const pathWithoutGit = pathHasGitSuffix ? normalizedPath.slice(1, normalizedPath.length - gitSuffix.length) : normalizedPath.slice(1);
	const pathSegments = pathWithoutGit.split('/').map(sanitizePathSegment);
	// Always normalize the canonical path to include .git so that URLs with and without the suffix deduplicate.
	const canonicalPath = pathHasGitSuffix ? normalizedPath.slice(1).toLowerCase() : `${normalizedPath.slice(1).toLowerCase()}${gitSuffix}`;

[connor4312]

@copilot apply changes based on this feedback

[Copilot]

Done in 5c6077a — introduced a gitSuffix constant in both parseUriMarketplaceReference and normalizeGitRepoPath, replacing all -4 magic numbers and repeated '.git' literals.

[Copilot]

Same maintainability concern here: '.git' and -4 are duplicated in suffix handling. Reusing a shared gitSuffix constant and slicing with -gitSuffix.length would make this easier to maintain and less error-prone.